Fix missing overlays, multiselect UX, and language propagation#10
Open
afffe18 wants to merge 1 commit intocodex/restore-ui-language-toggle-positionfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
coloredAreas,annotations) were not rendered on the plot and thus invisible in the plot view.select multiplecontrols made non-adjacent selection awkward and required Ctrl/Cmd, hurting usability for axis columns and whitelist keywords.Config versionwas exposed as an editable setting but should not be displayed in the user settings UI.Description
coloredAreasas filled polygon traces and convertannotationsinto Plotly layout annotations so overlays appear on the chart, addingAreaTraceandgetPlotAnnotationshelpers insrc/components/PlotPage.tsxand including those traces/annotations in the returned plot data.MultiSelectInput) used for axis columns and whitelist keywords, allowing non-adjacent selection without keyboard modifiers and deduplicating selections viaSetinsrc/App.tsx.UI_LABELSdictionary andt()helper, wiring the top-right toggle to update visible labels/buttons and making many field labels uset(...)insrc/App.tsx.updateLanguagesso newplotLanguagesinherit existing values for frame titles, dataframelegendTitle, and axislabelsinstead of creating empty entries, and remove the user-editableConfig versionfield from the settings UI.Testing
npm run lintand it completed successfully.npm run build(TypeScript compile + Vite build) and it completed successfully producing the production build.Codex Task