Refine config editor UX, multilanguage support, and render all layers#6
Open
afffe18 wants to merge 1 commit intocodex/refactor-plotconfig-files-and-update-ui-layoutfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
plotLanguagesto the dataframe type and default config and removed several unused empty-string defaults fromcreateDefaultPlotConfigto avoid emitting unused keys (changes insrc/config/defaultPlotConfig.ts).plot_languages/plotLanguagesfrom imported configs and populateplotLanguagessafely (changes insrc/config/configMappers.ts).src/App.tsxto provide an editable JSON popup with anApply JSONaction, separate dataframe and frame inputs, compact+add buttons, per-axis boxed cards for clearer boundaries, multilanguage controls (comma input + chips + per-language title/legend/axis label inputs), all layers shown/edited at once, and advanced JSON textarea fields forfilter,guidelines,annotations,coloredAreas, andhighlightedHulls.src/components/PlotPage.tsxto render traces for all layers (grouped by layer and material) and removed the top plot-statistics cards; also adjusted legend title logic.Testing
npm run build, which completed successfully (TypeScript compile + Vite build succeeded).Codex Task