This repository was archived by the owner on Apr 9, 2021. It is now read-only.
795 implement ui for initial filters#10
Merged
echappen merged 4 commits intospotlight-3.0from Nov 5, 2020
Merged
Conversation
When field is selected and it's filterable. the appropriate filter will appear underneath the checkbox Pending: passing Unit tests for UI components
Since filter fields are hidden until field is selected, user should know which fields can be filtered up-front. places icon of filter next to filterable field checkbox labels
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
|
||
| const Dropdown = (props) => { | ||
| return ( | ||
| <select |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
|
|
||
| const TextInput = (props) => { | ||
| return ( | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.