Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Add basic UI interactivity for field selection#7

Merged
echappen merged 3 commits intospotlight-3.0from
788-basic-ui-interactivity
Nov 4, 2020
Merged

Add basic UI interactivity for field selection#7
echappen merged 3 commits intospotlight-3.0from
788-basic-ui-interactivity

Conversation

@echappen
Copy link
Copy Markdown

@echappen echappen commented Nov 3, 2020

18F/site-scanning#788

  • Adds Redux for global state management

  • Available Fields and Selected Fields components pull data from redux state

  • Available Fields components add fields to redux state

  • Selected Field buttons remove fields from redux state

  • Uses React Testing Library with a custom Redux wrapper to unit test new components

  • Adds Unit testing for each redux reducer

18F/site-scanning#788
- Adds Redux for global state management
- Available Fields and Selected Fields components pull data from redux state
- Available Fields components add fields to redux state
- Selected Field buttons remove fields from redux state

- Uses React Testing Library with a custom Redux wrapper to unit test new components
- Adds Unit testing for each redux reducer
Copy link
Copy Markdown

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@echappen echappen merged commit 79f136d into spotlight-3.0 Nov 4, 2020
@echappen echappen deleted the 788-basic-ui-interactivity branch November 4, 2020 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant