-
Notifications
You must be signed in to change notification settings - Fork 25
Remove the postgresql package in favor of simplestore #1844
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1844 +/- ##
===========================================
- Coverage 88.25% 83.97% -4.28%
===========================================
Files 887 911 +24
Lines 20223 21501 +1278
Branches 3030 3219 +189
===========================================
+ Hits 17846 18054 +208
- Misses 1777 2478 +701
- Partials 600 969 +369
Continue to review full report at Codecov.
|
|
@ryanhofdotgov I've got to go to bed and be done. This PR is big and good, however, the merge into the mainline is still big and to be done. I've gotten started on it but I'm not done. I would really like to get this in before we roll off, but understand if we want to code freeze instead. I think that if you're planning to cut a full release and do a merge then it's probably worth waiting on this code, I should probably be the person to do the merge since I've been thinking about it. But I'd love for you to review it and I can address comments when I'm back. Take Care, |
ryanhofdotgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice to clean up – thanks! Aside from putting that code in a transaction, my main request on this one is that we have a full round of manual testing using the downstream fork this week; i.e., merge it in a downstream branch, test it out ahead of our end of sprint. And that @kdolan-soliel understands the motivation and approach here.
| func (s SimpleStore) SetAccountPasswordHash(account api.Account) error { | ||
|
|
||
| // delete an existing one, if it exists | ||
| deleteQuery := `DELETE FROM basic_auth_memberships WHERE account_id = $1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not super important since this is code that is just used for dev, but I'd put these 2 statements in a transaction.
Doesn't affect production, can be done in follow-up
Description
To simplify our db situation, this PR removes the rest of the old go-pg based database code. The last stuff that it was doing related to accounts has been implemented in simplestore using the new patterns. Getting rid of the last vestiges of the db code feels good!
There are a couple things left to do:
Checklist for Reviewer
More details about this can be found in docs/review.md