Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add placeholder page for Code Review guides #1

Merged
cmc333333 merged 1 commit into from
Oct 1, 2015
Merged

Add placeholder page for Code Review guides #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pages/code-collaboration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ Review Code
-----------

A team member other than the author reviews the pull request. They follow
Code Review guidelines (forthcoming) to avoid
miscommunication.
[Code Review guidelines] to avoid miscommunication.

They make comments and ask questions directly on lines of code in the GitHub
web interface or in the project's chat room.
Expand All @@ -92,6 +91,7 @@ lets the reviewer know it's ready to be reviewed again.
Repeat until all comments have been addressed. The reviewer then merges the PR
and deletes the branch.

[Code Review guideline]: {{ site.baseurl }}/code-review/
Merge
-----

Expand Down Expand Up @@ -124,4 +124,4 @@ Delete your local feature branch.

git branch --delete <branch-name>

[find the pull request]: http://stackoverflow.com/a/17819027
[find the pull request]: http://stackoverflow.com/a/17819027
6 changes: 6 additions & 0 deletions pages/code-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
permalink: /code-review/
title: Code Review
---

# Code Review