Skip to content
This repository was archived by the owner on Dec 17, 2021. It is now read-only.

Update to use the latest trustymail#302

Merged
IanLee1521 merged 2 commits intomasterfrom
improvement/update_to_latest_trustymail
Apr 10, 2019
Merged

Update to use the latest trustymail#302
IanLee1521 merged 2 commits intomasterfrom
improvement/update_to_latest_trustymail

Conversation

@jsf9k
Copy link
Collaborator

@jsf9k jsf9k commented Apr 4, 2019

The latest trustymail prints out the text sent and received during the SMTP exchange. This is very useful for debugging. See cisagov/trustymail#114 for more details.

It also forces smtplib to use IPv4 addresses for mail servers. The IPv6 addresses cause problems when running in AWS Lambda, at least inside a VPC. See cisagov/trustymail#115 for more details.

The latest trustymail prints out the text sent and received during the
SMTP exchange.  This is very useful for debugging.
@jsf9k jsf9k requested a review from a team April 4, 2019 17:26
Copy link
Contributor

@IanLee1521 IanLee1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IanLee1521 IanLee1521 merged commit db8a515 into master Apr 10, 2019
@IanLee1521 IanLee1521 deleted the improvement/update_to_latest_trustymail branch April 10, 2019 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments