Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Comments

Project view by Engagement Management lines#1250

Merged
Jkrzy merged 9 commits intomainfrom
nmb/1243-engagement
Jul 29, 2021
Merged

Project view by Engagement Management lines#1250
Jkrzy merged 9 commits intomainfrom
nmb/1243-engagement

Conversation

@neilmb
Copy link
Contributor

@neilmb neilmb commented Mar 10, 2021

Description

This addresses #1243 by adding a new view at projects/engagement. It lists only active projects that have "matching" engagement management lines where matching means the engagement management line ends with "Engagement Management" and it starts with the full name of another project line. (This does miss some pairs where they don't use exactly the same names.)

The total number of hours billed for the project and EM line are computed and the projects are listed in descending order of the ratio of those hours (more relative engagement management time is listed first).

Additional information

Screen Shot 2021-03-10 at 10 47 24

Copy link

@Jkrzy Jkrzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilmb this is a super interesting hypothesis to test!

We're missing a navigable path to these reports from the interface, let's add a link from the View Reports drop down.

@Jkrzy
Copy link

Jkrzy commented Mar 24, 2021

After this rolls out, let's set a check-in point a month or so into the future to evaluate if this is an informative way to look at project tocking. At that time we'll chat with the COO and make a decision on a next iteration or retiring this.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #1250 (4af2916) into main (be1dd33) will decrease coverage by 0.53%.
The diff coverage is n/a.

❗ Current head 4af2916 differs from pull request most recent head b0cb26b. Consider uploading reports for the commit b0cb26b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   88.56%   88.02%   -0.54%     
==========================================
  Files          51       51              
  Lines        2204     2222      +18     
==========================================
+ Hits         1952     1956       +4     
- Misses        252      266      +14     
Impacted Files Coverage Δ
projects/views.py 70.83% <0.00%> (-29.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1dd33...b0cb26b. Read the comment docs.

@kfoley-18F
Copy link
Contributor

I would like to get this merged soon. @neilmb - do you have time to add a nav link? Joe had suggested to the View Reports dropdown, I can also see making View Projects a dropdown instead of a static menu item, and having "All Projects" go to the current view and "Project reports" go to this one. (or something similar...) If you are buried, let me know and I'll get some other dev help for picking up this item and getting it over the line.

Many thanks for this!!!

@neilmb
Copy link
Contributor Author

neilmb commented Jul 28, 2021

Added a second-level menu for "View Projects" and used the names "All Projects" for /projects/ and "Engagement Levels" for /projects/engagement/. Happy to change the names if they are not clear.

Screen Shot 2021-07-28 at 09 33 10

@neilmb
Copy link
Contributor Author

neilmb commented Jul 28, 2021

@kfoley-18F Changed as requested, tests finally pass, ready for re-review.

Copy link
Contributor

@kfoley-18F kfoley-18F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! thank you!!
LGTM

@kfoley-18F
Copy link
Contributor

@Jkrzy - does this satisfy your change request??

@Jkrzy Jkrzy merged commit 94afc53 into main Jul 29, 2021
@Jkrzy Jkrzy deleted the nmb/1243-engagement branch July 29, 2021 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants