Skip to content

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Nov 20, 2025

What this PR does / why we need it?

image image

对 core 分析的时候发现日志初始化函数常驻了惊人的 27MB 内存。多次测试后发现日志队列配置了一个错误的值
错误代码来自于这个 pr 的合并 #10000
image
搞错了 make(chan []byte,#size ) 和 make([]byte, #size ) 导致创建了一个长度高达一百万的队列。

Summary of your change

修复 pr 产生的严重 bug,并额外设置了队列常量,给了一个较为保守的值 1024 (实际上可能几百都很难到)。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 20, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud wanghe-fit2cloud merged commit 8656dad into 1Panel-dev:dev-v2 Nov 20, 2025
0 of 3 checks passed
@HynoR HynoR deleted the fix/qz branch November 21, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants