Skip to content

fix: correct suitable log queue size to improve performance #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

fix: correct suitable log queue size to improve performance #11008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48dfa8
fix: Update log queue size to improve performance and ensure proper h…
HynoR Nov 20, 2025
d8d9036
fix: Adjust log queue size to maintain consistency with queue size limit
HynoR Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/log/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ package log

import (
"errors"
"github.com/1Panel-dev/1Panel/core/constant"
"io"
"os"
"path"

"github.com/1Panel-dev/1Panel/core/constant"
)

var (
Expand All @@ -14,6 +15,7 @@ var (
DefaultFileFlag = os.O_RDWR | os.O_CREATE | os.O_APPEND
ErrInvalidArgument = errors.New("error argument invalid")
QueueSize = 1024
LogQueueSize = 1024
ErrClosed = errors.New("error write on close")
)

Expand Down
5 changes: 3 additions & 2 deletions core/log/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package log

import (
"github.com/1Panel-dev/1Panel/core/constant"
"log"
"os"
"path"
Expand All @@ -11,6 +10,8 @@ import (
"sync/atomic"
"time"

"github.com/1Panel-dev/1Panel/core/constant"

"github.com/1Panel-dev/1Panel/core/global"
)

Expand Down Expand Up @@ -98,7 +99,7 @@ func NewWriterFromConfig(c *Config) (RollingWriter, error) {

var rollingWriter RollingWriter
writer := Writer{
queue: make(chan []byte, BufferSize),
queue: make(chan []byte, LogQueueSize),
m: mng,
file: file,
absPath: filepath,
Expand Down
Loading