Skip to content

feat(ai-agents): add anthropic-messages support for custom account #12013

Merged
zhengkunwang223 merged 1 commit intodev-v2from
pr@dev-v2@common
Mar 2, 2026
Merged

feat(ai-agents): add anthropic-messages support for custom account #12013
zhengkunwang223 merged 1 commit intodev-v2from
pr@dev-v2@common

Conversation

@zhengkunwang223
Copy link
Member

No description provided.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 2, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit 8cead06 into dev-v2 Mar 2, 2026
3 checks passed
@zhengkunwang223 zhengkunwang223 deleted the pr@dev-v2@common branch March 2, 2026 05:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38b922f1b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1424 to +1428
primaryID := customPrimaryModelID(customModelID)
if primaryID == "" {
primaryID = customModelID
}
primary := "custom/" + primaryID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep custom primary model ID consistent with configured model

For custom accounts, this now derives primary from only the last path segment (e.g. anthropic/claude-3-5-sonnet becomes custom/claude-3-5-sonnet), while the configured model entry keeps the full ID (customModelID). When a custom model name contains / (common with gateway-style model IDs), agents.defaults.model.primary no longer points at the same model entry written under models.providers.custom.models, so the agent can resolve an undefined/wrong default model at runtime.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants