feat: improve container log viewer and download options#12025
feat: improve container log viewer and download options#12025f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ssongliu
changed the title
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34ddd8e727
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const onDownload = async () => { | ||
| logSearch.tail = 0; | ||
| const customTail = Number(downloadForm.tail); | ||
| if (Number.isNaN(customTail) || customTail < 0) { |
There was a problem hiding this comment.
The new free-form tail input (allow-create) accepts values like 1.5, but the guard here only rejects NaN and negatives, so decimals pass and are sent to DownloadFile(params). On the server side, Tail is bound as uint (agent/app/dto/container.go), so non-integer numeric input causes request binding/validation failure and the download action breaks for users who enter fractional values. Add an integer-only check before submitting.
Useful? React with 👍 / 👎.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
deleted the
codex/container-log-xterm-download-dialog-i18n
branch
3 participants
#11898