fix(core): resolve operation data by agent for non-local nodes#12136
fix(core): resolve operation data by agent for non-local nodes#12136wanghe-fit2cloud merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d809e0b5a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (len(currentNode) == 0 || currentNode == "local") && | ||
| !strings.HasPrefix(record.Path, "/core") | ||
| allowCoreFallback := strings.HasPrefix(record.Path, "/core/xpack") || !willProxy(c.Request.URL.Path, currentNode) | ||
| needAgentResolve := len(operationDic.BeforeFunctions) != 0 && len(currentNode) != 0 && currentNode != "local" && !strings.HasPrefix(record.Path, "/core") |
There was a problem hiding this comment.
This condition now disables X-Need-Op-Resolve whenever CurrentNode is empty or local, but those requests are still proxied to the local agent (core/init/router/proxy.go, Proxy), so we lose the pre-operation metadata lookup for local-node actions. For delete-style APIs that hard-delete rows (for example /files/favorite/del, where favoriteService.Delete calls repo.Delete), the fallback DB lookup runs only after c.Next() and can no longer find the record, so operation logs regress to missing placeholders instead of resolved names/paths.
Useful? React with 👍 / 👎.
3 participants
No description provided.