feat: improve the OpenClaw terminal#12230
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d37a62772
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| containerID: row.containerName, | ||
| title, | ||
| users: ['node', 'root'], | ||
| shell: '/bin/bash', |
There was a problem hiding this comment.
/bin/bash for every agent terminal
The add/update flow still supports custom editCompose/dockerCompose agents, so the runtime image is user-defined rather than guaranteed to be the stock OpenClaw container. Hard-coding /bin/bash here removes the shell selection that the previous shared container terminal provided, which means any agent deployed from an Alpine/minimal/custom image that only ships /bin/sh or /bin/ash will now fail to open a terminal from the agent page.
Useful? React with 👍 / 👎.
| const initTerm = async () => { | ||
| terminalOpen.value = true; | ||
| await nextTick(); | ||
| let args = `source=container&containerid=${form.containerID}&user=${form.user}&command=${form.shell}`; |
There was a problem hiding this comment.
App installs can legitimately hold multiple container names: agent/app/service/app_utils.go persists strings.Join(containerNames, ","), and the old terminal dialog split that value before execing. This replacement forwards row.containerName unchanged into containerid=..., so an agent created from a multi-service custom compose will try docker exec foo,bar ..., which Docker rejects and leaves the terminal unusable.
Useful? React with 👍 / 👎.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
No description provided.