fix: align compose partial status actions#12239
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97d564720d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| :disabled=" | ||
| row.containerCount === row.runningCount && | ||
| row.runningCount > 0 | ||
| " | ||
| @click="handleComposeOperate('up', row)" |
There was a problem hiding this comment.
up as Start for partial compose apps
When a compose project is only partially running, this change newly enables the Start menu item, but that path still calls handleComposeOperate('up', row), which reaches ComposeOperation/compose.Up() and runs docker compose up -d for the whole project. Docker documents up as building, (re)creating, and starting services, so if the compose file or image tags changed since the healthy containers were launched, using Start to recover one stopped service can also recreate currently running containers. That regression is specific to partial projects introduced by this patch.
Useful? React with 👍 / 👎.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Refs #12232