fix: auto-allow firewall port when creating website with non-standard port#12267
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: auto-allow firewall port when creating website with non-standard port#12267jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
… port (1Panel-dev#12233) When creating a new website with a non-standard port, the firewall was not automatically updated. The getWebsiteDomains() return value for addPorts was being discarded. This already worked correctly when adding domains to an existing website (website_domain.go:35). Now calls OperateFirewallPort() with the new ports, matching the existing behavior in CreateWebsiteDomain. Fixes 1Panel-dev#12233
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12233 - Creating a website with a non-standard port does not auto-allow the port in the firewall, but adding a domain with a non-standard port to an existing website does.
Root Cause
In
agent/app/service/website.goline 305,getWebsiteDomains()returnsaddPortsas the second value, but it was being discarded with_:Meanwhile,
website_domain.go:30-35correctly captures and usesaddPorts:Fix
Capture
addPortsand callOperateFirewallPort()inCreateWebsite, matching the existing pattern inCreateWebsiteDomain.Changed file
agent/app/service/website.go(+7, -1)