fix: container backup should not fail entirely on mount copy errors#12276
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: container backup should not fail entirely on mount copy errors#12276jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
…Panel-dev#12236) When backing up a container with large mounted directories, if the copy fails (e.g., insufficient disk space), the entire backup task would fail and get stuck in "running" state in the task center. Now mount copy failures are logged and recorded with status "failed" in the backup metadata, but the backup continues with remaining mounts and completes successfully with partial data. This prevents the task from hanging indefinitely. Fixes 1Panel-dev#12236
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12236 - Container backup fails and gets stuck in "running" state when a mounted directory is too large or disk runs out of space.
Root Cause
In
stepBackupContainerMounts(), whenCopyDirWithNewNameorCopyFilefails for any mount, the function returns the error immediately, causing the entire backup task to fail. With large bind mounts, this is common (disk full, permissions, etc.).Fix
Mount copy failures are now non-fatal:
global.LOG.Errorfstatus: "failed"with the error messageBefore:
After:
Changed file
agent/app/service/backup_container.go(+10, -2)