feat: update default model config#12403
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44f533fe63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ContextWindow: model.ContextWindow, | ||
| MaxTokens: model.MaxTokens, |
There was a problem hiding this comment.
normalizeAgentAccountModel now stores ContextWindow and MaxTokens exactly as provided, without falling back to catalog/runtime defaults. That is a regression for upgrade paths where legacy model payloads are ID-only (e.g. migration-built records), because zeros are now persisted and later propagated by buildOpenclawAccountModelRuntime into agent runtime params, producing invalid MAX_TOKENS/CONTEXT_WINDOW values and broken OpenClaw startup after sync.
Useful? React with 👍 / 👎.
|
|
||
| func Get(key string) (Meta, bool) { | ||
| meta, ok := catalog[strings.ToLower(strings.TrimSpace(key))] | ||
| meta, ok := catalog[key] |
There was a problem hiding this comment.
Catalog lookups are now exact-string matches, but account creation/update flows still pass raw provider strings through (no canonicalization). Inputs like "OpenAI" or trailing-space variants were previously accepted and resolved; now they miss the catalog, so default base URL/env-key resolution fails and downstream verification/config generation can break (including malformed verify URLs when base URL is empty).
Useful? React with 👍 / 👎.
3 participants
No description provided.