refactor: restore symlink-based xpack integration#12473
refactor: restore symlink-based xpack integration#12473zhengkunwang223 merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08090b9ebb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| //go:build !xpack | |||
| //go:build !xpack && !xpackee | |||
There was a problem hiding this comment.
With this change, agent no longer has any implementation selected when building with -tags xpackee: the community files now require !xpack && !xpackee, while the only new replacements are tagged xpack (not xpackee). In that build mode, packages like agent/utils/xpack, agent/router, and agent/server lose required symbols (or all files), so enterprise builds that use the xpackee tag fail to compile.
Useful? React with 👍 / 👎.
3 participants
No description provided.