feat: Optimize the openclaw channel bot add flow#12507
feat: Optimize the openclaw channel bot add flow#12507f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 896c1f7a73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if defaultBot.AppID != "" || defaultBot.AppSecret != "" { | ||
| bots = append(bots, defaultBot) | ||
| } |
There was a problem hiding this comment.
This filter drops the default bot whenever top-level appId/appSecret are empty, even if accounts contains valid Feishu bots (a shape produced by earlier saves where only non-default accounts were configured). After this extraction, a normal save path calls getDefaultFeishuBot/setFeishuConfig, which promotes the first remaining account bot to default and omits it from accounts (because IsDefault is then true), silently changing account IDs/routing and breaking per-account pairing flows.
Useful? React with 👍 / 👎.
| if defaultBot.AppID != "" || defaultBot.ClientSecret != "" { | ||
| bots = append(bots, defaultBot) |
There was a problem hiding this comment.
The same omission here causes a regression for existing QQ configs that have empty top-level credentials but populated accounts: extraction now removes the placeholder default bot, and on the next save getDefaultQQBot/setQQBotConfig promotes the first account bot to default and skips writing it back into accounts. That silently rewrites channel structure and can invalidate account-based routing/pairing behavior.
Useful? React with 👍 / 👎.
3 participants
No description provided.