Skip to content

fix: correct listening status display on the firewall page#12516

Merged
ssongliu merged 1 commit into1Panel-dev:dev-v2from
looyeagee:fix-firewalld-listening
Apr 20, 2026
Merged

fix: correct listening status display on the firewall page#12516
ssongliu merged 1 commit into1Panel-dev:dev-v2from
looyeagee:fix-firewalld-listening

Conversation

@looyeagee
Copy link
Copy Markdown
Contributor

@looyeagee looyeagee commented Apr 17, 2026

What this PR does / why we need it?

The bug only appeared when the same process had both TCP and UDP sockets: every listening port on that process was attributed to whichever protocol was encountered first. For example, if a process listened on TCP 8000 and UDP 8001, the UI could wrongly show TCP 8001 as in use while UDP 8001 looked unused.
image

Summary of your change

Use (PID, conn.Type) as the cache key so each protocol has its own ListeningProcess entry.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

The bug only appeared when the same process had both TCP and UDP sockets:
every listening port on that process was attributed to whichever protocol
was encountered first. For example, if a process listened on TCP 8000 and
UDP 8001, the UI could wrongly show TCP 8001 as in use while UDP 8001
looked unused.

Use (PID, conn.Type) as the cache key so each protocol has its own
ListeningProcess entry.
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 17, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssongliu ssongliu merged commit 074c0ab into 1Panel-dev:dev-v2 Apr 20, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants