fix: Optimize the website name badge style.#12538
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3907bf008c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const shouldShowDomainTooltip = (domain: string) => { | ||
| return getDisplayDomain(domain).length > 30; |
There was a problem hiding this comment.
The new shouldShowDomainTooltip check gates the tooltip with getDisplayDomain(domain).length > 30, which is not tied to actual rendered overflow. Since this change also removed the column-level show-overflow-tooltip, domains can now be visually truncated in narrower table layouts (small screens, extra action buttons, wider glyphs/CJK) while the tooltip stays disabled, so users cannot access the full domain text from the list view.
Useful? React with 👍 / 👎.
3 participants
No description provided.