Skip to content

fix: adjust home dashboard styles#12549

Merged
wanghe-fit2cloud merged 1 commit intodev-v2from
fix/home-memo-system-info-style
Apr 21, 2026
Merged

fix: adjust home dashboard styles#12549
wanghe-fit2cloud merged 1 commit intodev-v2from
fix/home-memo-system-info-style

Conversation

@ssongliu
Copy link
Copy Markdown
Member

No description provided.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 21, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c07afda70a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
}
} finally {
setChartLoading(param, false);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Track concurrent requests before clearing loading flags

The loading state can become incorrect when search is triggered again before a prior request finishes (for example, rapid date-range changes, refresh clicks, or a chart-specific search while search('all') is still in flight). Because each request always executes setChartLoading(param, false) in finally, an older response can clear the spinner even though a newer request is still pending, and param === 'all' can clear every chart’s loading flag at once. This makes the UI indicate completion while data is still loading; using per-chart request counters/tokens would avoid this race.

Useful? React with 👍 / 👎.

@wanghe-fit2cloud wanghe-fit2cloud merged commit 8964730 into dev-v2 Apr 21, 2026
4 of 5 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the fix/home-memo-system-info-style branch April 21, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants