fix: adjust home dashboard styles#12549
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c07afda70a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
| } finally { | ||
| setChartLoading(param, false); |
There was a problem hiding this comment.
Track concurrent requests before clearing loading flags
The loading state can become incorrect when search is triggered again before a prior request finishes (for example, rapid date-range changes, refresh clicks, or a chart-specific search while search('all') is still in flight). Because each request always executes setChartLoading(param, false) in finally, an older response can clear the spinner even though a newer request is still pending, and param === 'all' can clear every chart’s loading flag at once. This makes the UI indicate completion while data is still loading; using per-chart request counters/tokens would avoid this race.
Useful? React with 👍 / 👎.
No description provided.