style: change table style#12552
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c6f11c67f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const visibleCount = hasDynamicShow.value ? props.ellipsis : staticVisibleCount.value; | ||
| const buttonsWidth = 35 + Math.max(visibleCount, 0) * 58 + 58; |
There was a problem hiding this comment.
Use the same cap as the rendering logic when computing width: getInlineButtons/hasMore only ever show up to ellipsis + 1 actions (inline + "more"), but this change uses staticVisibleCount directly when show is not dynamic. In tables with many static actions (for example 8–10 buttons and default ellipsis=2), the column width is overestimated by hundreds of pixels, causing avoidable table expansion and horizontal layout regression.
Useful? React with 👍 / 👎.
zhengkunwang223
force-pushed
the
pr@dev-v2@common
branch
from
4c6f11c to
0556ce5
Compare
3 participants
No description provided.