feat: remove some config for hermes channel#12560
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee777a5729
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allowFrom := splitHermesEnvList(envMap["DISCORD_ALLOWED_USERS"]) | ||
| requireMention := extractBoolValue(childMap(cfg, "discord")["require_mention"], true) | ||
| dmPolicy := "pairing" | ||
| requireMention := extractBoolValue(childMap(cfg, "discord")["require_mention"], false) |
There was a problem hiding this comment.
readHermesDiscordChannelConfig now treats a missing discord.require_mention as false, which flips the derived groupPolicy to open for configs that omit that key. In upgraded Hermes installs that only set env vars (or otherwise lack this YAML field), opening and saving the channel will silently persist the less restrictive behavior, so bots start responding in groups without mention-gating unless users manually notice and re-enable it.
Useful? React with 👍 / 👎.
3 participants
No description provided.