feat: change isProductPro logic#12712
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8c9ca10c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| globalStore.isEnterpriseLicensed = false; | ||
| } else { | ||
| globalStore.isEnterpriseLicensed = res.data.status === 'Bound'; | ||
| globalStore.isProductPro = globalStore.isEnterpriseLicensed; |
There was a problem hiding this comment.
When an enterprise license check previously returned Bound, this new assignment persists isProductPro = true; if a later enterprise status response is empty (!res || !res.data above), only isEnterpriseLicensed is cleared and isProductPro remains true. Since this commit changes multiple enterprise/pro gates to read isProductPro directly, an empty status response after a prior valid check can leave pro-only UI/API paths enabled even though the enterprise license was not confirmed.
Useful? React with 👍 / 👎.
3 participants
No description provided.