feat: remove env from mcp config#8337
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| prettyJson.value = JSON.stringify(jsonObj.value, null, 2); | ||
| open.value = true; | ||
| }; | ||
|
|
There was a problem hiding this comment.
The updated code introduces the Vue-Codemirror component to display the prettyJson string in a formatted manner using Markdown syntax. The codemirror extension is set up with JavaScript syntax highlighting and One Dark theme.
Recommendations:
1. Code Consistency: Ensure that the usage and spacing of tags like <template>, <el-input>, etc., follow the same convention throughout the template file.
Original vs. Updated Code:
- Original:
<el-input type="textarea" :autosize="{ minRows: 10, maxRows: 20 }"> {{ prettyJson }} </el-input>
- Updated:
<codemirror autofocus tabindex="0" placeholder="$t('commons.msg.noneData')" indent-with-tab tabSize="4" height="300px" lineWrapping matchBrackets=true theme="cobalt" styleActiveLine=true extensions="[javascript(), oneDark]" v-model="prettyJson" disabled=false>
Ensure consistent indentation and use proper HTML attributes without spaces.
2. Accessibility Consideration: The disabled="true" attribute on the Codemirror input element prevents it from being editable which can potentially confuse users as they might assume it’s interactive. If you intend for users to be able to edit the text while viewing, remove the disabled attribute.
Updated Code:
<codemirror autofocus tabindex="0" placeholder="$t('commons.msg.noneData')" indent-with-tab tabSize="4" height="300px" lineWrapping matchBrackets=true theme="cobalt" styleActiveLine=true extensions="[javascript(), oneDark]" v-model="prettyJson">By making these adjustments, the code will improve its readability and usability. Let me know if there's anything more needed!
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
No description provided.