Skip to content

fix: Fix issue with update website config #8610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
May 12, 2025
Merged

fix: Fix issue with update website config #8610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/app/service/website.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,9 @@ func (w WebsiteService) UpdateWebsite(req request.WebsiteUpdate) error {
}
}
website.PrimaryDomain = req.PrimaryDomain
website.WebsiteGroupID = req.WebsiteGroupID
if req.WebsiteGroupID > 0 {
website.WebsiteGroupID = req.WebsiteGroupID
}
website.Remark = req.Remark
website.IPV6 = req.IPV6

Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you've provided is already concise and well-formed without significant irregularities or potential issues. It appears that the change introduces a conditional check to ensure WebsiteGroupID is greater than zero before assigning it to the website object. This might be intended to prevent setting an invalid group ID if left set to 0 by the client request.

Here's a few minor optimizations you could consider:

  1. Simplify Boolean Check: The condition can be simplified using Go's short-circuit evaluation feature, which doesn't require parentheses.

    if req.WebsiteGroupID > 0 {
    website.WebsiteGroupID = req.WebsiteGroupID
} else {
    // Optionally handle the case when WebsiteGroupID is not valid
}

  2. Use Type Casting: If req.WebsiteGroupID must be an integer for further processing, casting can make the intent clearer.

    website.WebsiteGroupID = int32(req.WebsiteGroupID)

These small improvements enhance clarity and performance slightly, but they don't alter the functionality significantly.

Expand Down
Loading