feat: add domain validate for appinstall webUI

[zhengkunwang223]

Refs #8936

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wanghe-fit2cloud]

Some of the changes have been suggested to improve readability and maintainability:

1. In acceptParams, add a line to log parameters before updating:

params.value = [];
console.log("Received params:", JSON.stringify(props));

2. Update comment style consistency:

// Potential issue: The comments on lines 114, 129, and 165 should be consistent about their content type (e.g., all function docs).

Replace with something like:

/*
 * Function description goes here...
 */

3. Add spacing after commas in imports and declarations:

import { reactive, ref } from 'vue';
+import { FormInstance } from 'element-plus';

interface ParamProps {
  // ...
}

let webUI = reactive({
  serverUrl: '',
  username: '',
  password: '',
  domainName: '',

+ isDeployed: true,
});

4. Refactor check functions:

• Rename MsgError to showErrorMessage for clarity.
• Move duplicate if (!check...) {} else return false; checks into separate functions.

Here's an optimized version:

function showErrorMessage(message) {
  MsgError(i18n.global.t(`commons.msg.${message}`));
  throw new Error(); // Or some other mechanism to indicate failure
}

async function validateWebUI() {
  if (!webUI.domain || webUI.domain === '') {
    showErrorMessage('emptyHost');  
  }

  try {
    const [host, port] = webUI.domain.split(':').map(item => item.trim());

    if (!/^\d+$/.test(port)) {
      showErrorMessage('invalidPort');  
    }

    if (!(await checkIpAddressOrDomain(host)) || !isHostValid(port)) {
      showErrorMessage('invalidHost');  
    }
  } catch (error) {
    console.error(error);    
  } finally {
    return !!webUI.domain;
  }
}

const acceptParams = async (props: ParamProps): Promise<void> => {
    submitModel.value.installId = props.id;

    let errorOccurred = false;
    if (!validateWebUI()) {
        errorOccurred = true;
    }
    // Continue processing based on validation errors
};

Additional notes: Ensure that checkIpAddressOrDomain and isHostValid are implemented correctly according to your specific needs. Always include proper comments and documentation for these functions to avoid future maintenance challenges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wanghe-fit2cloud]

/lgtm

[wanghe-fit2cloud]

/approve

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wanghe-fit2cloud]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment