Skip to content

fix: lark document i18n error #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Mar 25, 2025
Merged

fix: lark document i18n error #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/locales/lang/en-US/views/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ export default {
},
larkSetting: {
title: 'Lark Configuration',
appIdPlaceholder: 'Please enter APP ID',
appSecretPlaceholder: 'Please enter APP secret',
appIdPlaceholder: 'Please enter App ID',
appSecretPlaceholder: 'Please enter App secret',
verificationTokenPlaceholder: 'Please enter verification token',
urlInfo:
'-Events and callbacks - event configuration - configure the "request address" of the subscription method',
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is correct and doesn't contain any irregularities or potential issues. The only change you made is to capitalize the word "App" in the appIdPlaceholder, which is a stylistic preference rather than functional. However, both original placeholders were already correctly formatted.

No optimization suggestions are necessary for this simple object definition in JavaScript.

Expand Down
1 change: 1 addition & 0 deletions ui/src/locales/lang/en-US/views/dataset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export default {
createDataset: 'Create Knowledge',
general: 'General',
web: 'Web Site',
lark: 'Lark',
relatedApplications: 'Linked App',
document_count: 'docs',
relatedApp_count: 'linked apps',
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is syntactically correct, free from grammatical errors, and does not contain significant optimization opportunities within its current structure. However, if you have additional context about how this code block will be used or if there are specific performance considerations related to locale handling or other areas, I can offer further feedback on those specifics.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/views/dataset/component/CreateDatasetDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
:placeholder="$t('views.application.applicationAccess.larkSetting.appIdPlaceholder')"
/>
</el-form-item>
<el-form-item label="App Secret" prop="app_id" v-if="datasetForm.type === '2'">
<el-form-item label="App Secret" prop="app_secret" v-if="datasetForm.type === '2'">
<el-input
v-model="datasetForm.app_secret"
type="password"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few minor issues:

  1. The placeholder text "App ID Placeholder" in the v-text directive is incorrectly spelled as "larkSetting".
  2. The attribute name used for binding to the datasetForm.app_secret in the input field should match the property key in the data object.

Here are the corrected lines of code:

@@ -151,7 +151,7 @@
           :placeholder="$t('views.application.applicationAccess.larkSetting.appIdPlaceholder')"
         />
       </el-form-item>
-      <el-form-item label="App Secret" prop="app_id" v-if="datasetForm.type === '2'">
+      <el-form-item label="App Secret" prop="app_secret" v-if="datasetForm.type === '2'">
         <el-input
           v-model="datasetForm.app_secret"
           type="password"

These changes ensure that the correct placeholders and form items are used throughout the component.

Expand Down