Skip to content

refactor: convert getList and getUserList functions to async for improved handling of asynchronous operations #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuruibin merged 2 commits into from
Apr 1, 2025
Merged

refactor: convert getList and getUserList functions to async for improved handling of asynchronous operations #2761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d77886b
refactor: conditionally render dropdown item based on init_field_list…
liuruibin Apr 1, 2025
cb7af57
refactor: convert getList and getUserList functions to async for impr…
liuruibin Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions ui/src/views/function-lib/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@
{{ $t('common.copy') }}
</el-dropdown-item>
<el-dropdown-item
v-if="item.init_field_list?.length > 0"
:disabled="item.permission_type === 'PUBLIC' && !canEdit(item)"
@click.stop="configInitParams(item)"
>
Expand Down Expand Up @@ -508,7 +509,10 @@ function importFunctionLib(file: any) {
})
}

function getList() {
async function getList() {
if (userOptions.value?.length === 0) {
await getUserList()
}
const params = {
...(searchValue.value && { name: searchValue.value }),
...(functionType.value && { function_type: functionType.value }),
Expand Down Expand Up @@ -544,28 +548,26 @@ function refresh(data: any) {
getList()
}

function getUserList() {
applicationApi.getUserList('FUNCTION', loading).then((res) => {
if (res.data) {
userOptions.value = res.data.map((item: any) => {
return {
label: item.username,
value: item.id
}
})
if (user.userInfo) {
const selectUserIdValue = localStorage.getItem(user.userInfo.id + 'function')
if (selectUserIdValue && userOptions.value.find((v) => v.value === selectUserIdValue)) {
selectUserId.value = selectUserIdValue
}
async function getUserList() {
const res = await applicationApi.getUserList('FUNCTION', loading)
if (res.data) {
userOptions.value = res.data.map((item: any) => {
return {
label: item.username,
value: item.id
}
})
if (user.userInfo) {
const selectUserIdValue = localStorage.getItem(user.userInfo.id + 'function')
if (selectUserIdValue && userOptions.value.find((v) => v.value === selectUserIdValue)) {
selectUserId.value = selectUserIdValue
}
// getList()
}
})
}
}

onMounted(() => {
getUserList()

})
</script>
<style lang="scss" scoped>
Expand Down