fix: The conversation page cannot be opened

[shaohuzhang1]

fix: The conversation page cannot be opened

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code appears to have some minor adjustments:

1. Condition check in URL construction: The original code uses window.MaxKB.chatPrefix directly without checking if it exists before concatenating with the origin and prefix. This can lead to an error if chatPrefix is not defined.

2. Parameter naming consistency: In the action method, you mentioned using a variable named id, but then used loading? Ref<boolean> which seems like TypeScript syntax for optionals, possibly intended to indicate whether a loading state is present.

Optimization Suggestion:

To improve robustness and maintainability, consider adding a default value to ensure that both chatPrefix and prefix are used if chatPrefix is indeed undefined. You could also extract this logic into a utility function or property if necessary.

Here's how you might structure the changes:

import appApi from '@/api/application/application'
import type { Ref } from 'vue'
const useApplicationStore = defineStore('application', {
   state: () => ({
     location: `${window.location.origin && window.MaxKB.chatPrefix}`
       ? `${window.location.origin}${window.MaxKB.chatPrefix}/`
       : `${window.location.origin}${window.MaxKB.prefix || ''}/`,
   }),
   actions: {
     async asyncGetApplicationDetail(id: string, loading?: Ref<boolean>) {
     // Your existing code here
     }
   },
})

By ensuring these checks and consolidations, your component should be more resilient and easier to understand.