Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Folder and Resource Selection Interaction Abnormality

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

multipleSelection.value = multipleTableRef.value.getSelectionRows()
} else {
multipleSelection.value = val
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you've provided is mostly correct with some minor optimizations and improvements:

  1. Simplified Condition: The condition inside the if statement can be simplified to directly check if an item exists in multipleSelection. This avoids iterating over the entire array twice.

Here's your updated code with this optimization:

const select = (val: any[], active: any) => {
  TreeToFlatten([active])
    .filter((item: any) => item.id !== active.id)
    .forEach((item: any) => {
      const isSelected = multipleSelection.value.some(s => s.id === item.id);
      
      // Toggle row selection only if it is not already selected
      if (!isSelected && multipleTableRef.value)
        multipleTableRef.value.toggleRowSelection(item, true);
    });

  multipleSelection.value = multipleTableRef.value.getSelectionRows();
};

Key Improvements:

  • Single Iteration Check: Reduced the need for filtering out items that cannot exist in multipleSelection.
  • Direct Selection Check: Use some() to check if an item is already selected without needing to iterate further through multipleSelection.

These changes make the function more efficient while maintaining its functionality.

@shaohuzhang1 shaohuzhang1 merged commit 9a46cac into v2 Oct 27, 2025
4 of 6 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_resource_auth branch October 27, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants