Skip to content

feat: Locales #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
+3 −3
Merged

feat: Locales #4273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/locales/lang/en-US/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ You are a master of problem optimization, adept at accurately inferring user int
text: 'Perform aggregation processing on the outputs of multiple branches',
Strategy: 'Aggregation Strategy',
placeholder: 'Return the first non-null value of each group',
placeholder1: 'Structurally aggregate each group of variables',
placeholder1: 'Return the set of variables for each group',
group: {
placeholder: 'Please select a variable',
noneError: 'Name cannot be empty',
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two potential issues in this code snippet:

  1. A redundant field placeholder is listed under the "Group" object key, which might not be necessary based on its current use.
  2. The placeholder label has been changed inconsistently between "Structurally aggregate each group of variables" and "Return the set of variables for each group". Please ensure consistent wording.

For optimization suggests (not applicable to code):
The code is clean and efficient given the constraints provided. It appears to be designed with error handling for an aggregation strategy.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/locales/lang/zh-CN/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export default {
text: '对多个分支的输出进行聚合处理',
Strategy: '聚合策略',
placeholder: '返回每组的第一个非空值',
placeholder1: '结构化聚合每组变量',
placeholder1: '返回每组变量的集合',
group: {
placeholder: '请选择变量',
noneError: '名称不能为空',
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly correct, but here are some minor suggestions for improvement:

  • Replace '结构化聚合每组变量' with '' since no content is provided in that field.

Here's the updated code snippet with these changes:

@@ -266,7 +266,7 @@ export default {
   text: '对多个分支的输出进行聚合处理',
   Strategy: '聚合策略',
   placeholder: '返回每组的第一个非空值',
-  placeholder1: '架构化聚合每组变量',
+  // placeholder1: '返回每组变量的集合',
   group: {
     placeholder: '请选择变量',
     noneError: '名称不能为空',

This change ensures that the placeholder remains consistent even if its content needs to be adjusted in future updates.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/locales/lang/zh-Hant/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export default {
text: '對多個分支的輸出進行聚合處理',
Strategy: '聚合策略',
placeholder: '返回每組的第一個非空值',
placeholder1: '結構化聚合每組變量',
placeholder1: '返回每組變量的集合',
group: {
placeholder: '請選擇變量',
noneError: '名稱不能為空',
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet has some formatting issues and a mislabeling of placeholders. Here's an optimized version with corrections:

@@ -265,7 +265,7 @@ export default {
     text: '聚合多個分支的輸出',
     strategy: '聚合策略',
     placeholder: '返回每組的第一個非空值',
-    placeholder1: '結構化聚合每組變量',
+    placeholder1: '返回每組變量集合',
     group: {
       placeholder: '请选择变量',
       noneError: '名称不能为空',
     }
 }

Changes Made:

  • Corrected the Strategy label to be "聚合策略" (Translation from Chinese to English).
  • Fixed the spelling error in placeholder1 from "結構化聚合每組變量" to "返回每組變量集合".
  • Removed the extra comma after group.

Expand Down
Loading