Skip to content

fix: When extracting parameters, input parameters that are not strings result in the node being unable to execute #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
+1 −0
Merged

fix: When extracting parameters, input parameters that are not strings result in the node being unable to execute #4276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...plication/flow/step_node/parameter_extraction_node/impl/base_parameter_extraction_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def save_context(self, details, workflow_manage):
self.context['request'] = details.get('request')

def execute(self, input_variable, variable_list, model_params_setting, model_id, **kwargs) -> NodeResult:
input_variable = str(input_variable)
self.context['request'] = input_variable
if model_params_setting is None:
model_params_setting = get_default_model_params_setting(model_id)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few issues that need to be addressed:

  1. Type Casting Issue: The line input_variable = str(input_variable) casts the input parameter regardless of its original type. This can lead to unexpected behavior if the input is not a string, such as numbers or other data types.

    Suggestion: Consider using implicit conversion instead of explicit casting if possible, but avoid this if you want to ensure consistency with the variable's expected type before use. If necessary, introduce a more targeted approach based on your application requirements.

  2. Code Style Mismatch:

    • Line 86 contains an extra space after -. In Python, consecutive whitespace characters are considered a single space.

  3. Function Documentation: Ensure that all functions have appropriate docstrings (Python documentation). While the function doesn't require much in terms of explanation given its simplicity, it's a good practice to maintain clarity.

Here's the optimized version of the code without addressing the type-casting issue for now:

class MyClass:
    def __init__(self):
        self.context = {}

    def save_context(self, details, workflow_manage):
        self.context['request'] = details.get('request')

    def execute(self, input_variable, variable_list, model_params_setting, model_id, **kwargs) -> 'NodeResult':
        if model_params_setting is None:
            model_params_setting = get_default_model_params_setting(model_id)

Addressing the type-casting issue requires more context about how and where this method is used within your larger application to determine the most appropriate handling strategy.

Expand Down
Loading