Skip to content

fix: Migration #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: Migration #4295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/system_manage/migrations/0003_alter_workspaceuserresourcepermission_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ def auth_folder(apps, schema_editor):
class Migration(migrations.Migration):
dependencies = [
('system_manage', '0002_refresh_collation_reindex'),
('tools', '0001_initial'),
('application', '0001_initial'),
('knowledge', '0001_initial'),
]

operations = [
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there appears to be an error in this migration file. The dependencies list should not include apps that are not required by the models being modified. Specifically:

  1. There is no system_manage.models mentioned.
  2. Although 'tool' app was previously added, it seems like an unnecessary dependency.

The correct line should be without the entries for 'tools' and 'knowledge':

dependencies = [
    ('system_manage', '0002_refresh_collation_reindex'),
]

Also, ensure that none of these dependencies have already been satisfied earlier in the migrations history (in previous versions), or you might cause circular references if they depend on each other.

Expand Down
Loading