Skip to content

fix: XF stt model #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix: XF stt model #4297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/models_provider/impl/xinference_model_provider/model/stt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def new_instance(model_type, model_name, model_credential: Dict[str, object], **
model=model_name,
api_base=model_credential.get('api_base'),
api_key=model_credential.get('api_key'),
params=model_kwargs,
**optional_params,
)

Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet appears to be a method for creating an instance of a model based on certain parameters and keyword arguments. However, there are a few areas where the code can be improved:

  1. Type Hinting: Ensure that type hints are complete and accurate. The Dict[str, object] is not very descriptive. It would be better if you could specify more concrete types for the keys and values.

  2. Optional Parameters: Make sure all optional parameters (api_base, api_key) have default values defined. This will prevent errors when calling the function without specifying these parameters unless required.

  3. Suggestion for Adding Params Keyword Argument: If you intended to include additional configuration options for the model instantiation, consider adding a specific parameter name (e.g., config) instead of using an arbitrary key model_kwargs. This makes it clearer what kind of data is expected here.

Here's a revised version of the code with these suggestions incorporated:

def new_instance(
    model_type: str,
    model_name: str,
    model_credential: Dict[str, Any],
    api_base: Optional[str] = None,  # Added default value
    api_key: Optional[str] = None,  # Added default value
    config: Optional[Dict[str, Any]] = None,  # Suggested new parameter
    **optional_params,
):

Explanation:

  • Type Hints: Updated type hinting to use str for model_type and model_name and Dict[str, Any] for model_credential and other dictionaries.
  • Default Values: Provided default values for api_base and api_key.
  • Additional Parameter: Introduced a new parameter config to handle potential additional configuration settings.
    This revision aims to enhance clarity, maintainability, and future-proofing the function by ensuring type consistency and providing clear usage guidelines through default parameters.

Expand Down
Loading