Skip to content

fix: Workflow Basic Node User Input Configurable Title #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 4, 2025
Merged

fix: Workflow Basic Node User Input Configurable Title #4439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/src/views/knowledge-workflow/component/action/KnowledgeBase.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
>
<template #default>
<h4 class="title-decoration-1 mb-16 mt-4">
{{ $t('chat.userInput') }}
{{ chat_title || $t('chat.userInput') }}
</h4>
</template>
</DynamicsForm>
Expand All @@ -26,6 +26,10 @@ const dynamicsFormRef = ref<InstanceType<typeof DynamicsForm>>()
const validate = () => {
return dynamicsFormRef.value?.validate()
}
const chat_title = computed(() => {
const kBase = props.workflow?.nodes?.find((n: any) => n.type === WorkflowType.KnowledgeBase)
return kBase.properties.user_input_config.title
})
const base_form_list = computed(() => {
const kBase = props.workflow?.nodes?.find((n: any) => n.type === WorkflowType.KnowledgeBase)
if (kBase) {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a checklist of common issues with front-end React components:

  1. Props Propagation: Ensure that workflow prop is correctly passed and not null before accessing its children nodes.

  2. Computed Properties:

    • The chat_title computed property uses a template string ($t) to translate strings directly from props.workflow. This can be problematic if there's no translation module provided.
    • It would be better to use Vuex store or similar state management solutions to centralize translations for easier maintenance.

  3. Null/Undefined Checks: Always add checks for null values when dealing with objects or arrays returned by APIs or component properties.

  4. Data Binding Errors:

    • In <template #default>, ensure $t returns the correct translated value, even if it might not exist due to previous steps.
    • Use optional chaining or default parameters where needed to prevent errors when data might not be available initially.

  5. Component Naming Convention: Class names and function names should be kebab-case for consistency across projects.

  6. Performance Considerations: If dynamicsFormRef.value?.validate() might execute frequently, consider debouncing this method call to avoid unnecessary re-renders.

  7. Accessibility:

    • Add ARIA attributes where necessary for screen readers to accurately interpret components like dropdown menus.
    • Ensure proper focus handling during user interactions.

  8. Dynamic Content Injection: Be cautious about dynamic content in templates, especially regarding XSS attacks, by sanitizing data as appropriate.

To optimize your code further without altering its functionality significantly:

  • Extract complex logic into reusable functions.
  • Move stateful variables outside the render cycle using refs to avoid unnecessary updates.
  • Use functional hooks rather than classes where applicable to improve performance and type safety.

Implement these improvements to make your application more robust and efficient.

Expand Down
5 changes: 4 additions & 1 deletion ui/src/workflow/nodes/knowledge-base-node/component/UserInputFieldTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ onMounted(() => {
if (props.nodeModel.properties.user_input_field_list) {
inputFieldList.value = cloneDeep(props.nodeModel.properties.user_input_field_list)
}

if (props.nodeModel.properties.user_input_config) {
inputFieldConfig.value = props.nodeModel.properties.user_input_config
}
set(props.nodeModel.properties, 'user_input_config', inputFieldConfig)
onDragHandle()
})
</script>
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code makes several improvements compared to the original:

  1. Initialization of inputFieldConfig: A variable named inputFieldConfig is initialized using props.nodeModel.properties.user_input_config. This ensures that it's properly scoped and accessible within the closure.

  2. Assignment back to nodeModel: The line set(props.node_model, 'user_input_config', input_field_config) assigns the value of inputFieldConfig back to nodeModel, which updates the prop accordingly.

  3. Simplified Condition Check: The condition check for user_input_field_list remains the same, cloning the list into inputFieldList.

  4. Comments Added: Comments are added before each block of code where new logic is introduced for clarity.

Overall, the changes enhance readability and maintainability by organizing related logic together and initializing variables appropriately. These optimizations prevent potential issues such as undefined properties and ensure that the state is correctly managed.

Expand Down
Loading