Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

…ormat

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 11a894f into v2 Dec 10, 2025
1 of 3 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_workflow branch December 10, 2025 08:28
file_type_list: ['TXT', 'DOCX', 'PDF', 'HTML', 'XLS', 'XLSX', 'ZIP', 'CSV', 'MD'],
file_size_limit: 100,
file_count_limit: 50,
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code seems to have two main areas where changes could be made:

  1. File Type Options: The new option "MD" (Markdown) has been added to file_type_list_options, which is correct.
  2. Form Initializations: In the form object, the initial values have not changed after adding the new file type, so they should remain consistent.

There are no apparent syntax errors or major issues with the current code. However, consider updating the documentation of what these options mean if it helps clarify their use in a larger system.

Here's a slight update to ensure consistency and maintain readability:

import { ref } from 'vue';
import { defineProps } from 'vue';

const NodeFormRef = ref();
const props = defineProps<{
  nodeModel: any;
}>();

// Add MD file type to existing list
const file_type_list_options = ['TXT', 'DOCX', 'PDF', 'HTML', 'XLS', 'XLSX', 'ZIP', 'CSV', 'MD'];

// Keeping existing default settings
const form = {
  file_type_list: file_type_list_options.slice(0), // Ensure default types match the updated options list
  file_size_limit: 100,
  file_count_limit: 50,
};

console.log(form); // For checking purposes

This ensures that the file_type_list reflects all available options while still initializing based on the previous logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants