Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Local rearrangement model cannot be added

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 12, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

return model

cache_folder = forms.TextInputField(_('Model catalog'), required=True)
cache_dir = forms.TextInputField(_('Model catalog'), required=True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code snippet you provided contains an error: it attempts to define two fields with the same name (cache_folder and cache_dir) using different class attributes. This will likely result in a runtime exception because Python does not allow duplicate attribute names within the same class.

To fix this, you can either use one of the field names consistently or modify the cache_dir definition to include additional information if needed, such as setting its initial value:

class MyForm(forms.Form):
    # ... other fields ...

    cache_folder = forms.TextInputField(_('Model catalog'), required=True)

    def encryption_dict(self, model: Dict[str, object]):
        return model

If there was no specific intention to have different fields, simply update the existing cache_folder with an appropriate field instance if necessary. If you intended to add new functionality related to directories instead of form caching, ensure that both fields work together appropriately without ambiguity.

@shaohuzhang1 shaohuzhang1 merged commit d393e28 into v2 Dec 12, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_local_model branch December 12, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants