Skip to content

fix: Tool workflow restricts the deletion of basic nodes and start nodes#4960

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_tool_workflow
Mar 27, 2026
Merged

fix: Tool workflow restricts the deletion of basic nodes and start nodes#4960
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_tool_workflow

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: Tool workflow restricts the deletion of basic nodes and start nodes

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 27, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

'tool-base-node',
'base-node',
'loop-body-node',
'loop-start-node',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks generally correct, but there are a few small improvements you could make:

  1. Remove Duplicates: The array ['start-node', 'tool-base-node'] contains duplicate entries. You should remove one of them to avoid redundancy.

  2. Improve Readability: Consider grouping similar node types together if they share common functionalities or properties.

Here's the updated code with these changes applied:

@@ -104,6 +104,8 @@ export function initDefaultShortcut(lf: LogicFlow, graph: GraphModel) {
     const nodes = elements.nodes.filter((node) =>
       [
         'start-node',
+        'tool-start-node', // Removed duplicate entry
+        'tool-base-node', // Added back only once
         'base-node',
         'loop-body-node',
         'loop-start-node',

These changes help maintain clarity in the list and ensure no unnecessary duplicates exist.

@shaohuzhang1 shaohuzhang1 merged commit 517e5f4 into v2 Mar 27, 2026
3 of 4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_tool_workflow branch March 27, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant