Merged
Conversation
Progdrasil
force-pushed
the
windows-provider-api-adaptations
branch
from
6dc0148 to
314dcb7
Compare
iinuwa
approved these changes
Dec 29, 2025
Contributor
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
These changes look good!
Just added a note about serde_workaround.
Progdrasil
force-pushed
the
add-passkey-accessor-trait
branch
from
8c85319 to
ec57ee0
Compare
Progdrasil
force-pushed
the
windows-provider-api-adaptations
branch
from
314dcb7 to
abe361d
Compare
Vogeltak
approved these changes
Jan 6, 2026
Collaborator
Vogeltak
left a comment
Vogeltak
left a comment
There was a problem hiding this comment.
No additional comments :)
Progdrasil
force-pushed
the
add-passkey-accessor-trait
branch
from
ec57ee0 to
1ecc79b
Compare
Progdrasil
force-pushed
the
windows-provider-api-adaptations
branch
from
abe361d to
577e097
Compare
This breaks the rusty syntax but fixes ambiguity around the default keyword whitch was being miss-interpreted. Ideally this would be a TT muncher macro but thats a lot more work than I have time to put into this
Just like their webauthn equivalents
All the other fields from ctap2.2 have also been added to get_info for future use
firefox is not happy with the capitalization of none, which is fair since its not spec compliant
Progdrasil
force-pushed
the
windows-provider-api-adaptations
branch
from
577e097 to
a0d6fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides various changes that were necessary for the windows API integration. Namely:
serde_workaroundmacro around the use of the default keyword.Commit by commit review recommended