Update health check path to /app to avoid 307 redirect#162
Merged
devilleweppenaar merged 1 commit intomasterfrom Dec 10, 2021
Merged
Conversation
Closed
devilleweppenaar
deleted the
chas/1793-scim-bridge-health-check-responding-with-307
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of a
307 Temporary Redirectresponse code being returned from/, configs using/as the health check are continually failing and recreating the ECS task, resulting in broken bridges.Prior to release
v2.3.0of the SCIM bridge, hittingGET /would return a200if everything was healthy, and therefore was a proper path for health checks. Now withv2.3.0we are redirecting/to/appin order to serve the new React app, so defining/appas the health check path by default gets us to a working state.Since release
v2.3.0, users can also enable an optional ping server on/pingfor health check purposes. This will be the way forward as the default for our helm charts, but this requires theOP_PING_SERVERoption to be enabled, so for this ECS Fargate terraform config we'll need to keep it as/app.