Skip to content

Conversation

@ag-rdoucette
Copy link
Collaborator

Pull Request Description

This PR updates the op-scim-bridge.yaml and op-scim-bridge-gw.yaml configurations for the Cloud Run 1Password SCIM bridge to address timing issues where the scim container attempts to connect to redis before it is fully operational.

Changes

  • Added run.googleapis.com/container-dependencies annotation to both op-scim-bridge.yaml and op-scim-bridge-gw.yaml to ensure the scim container starts only after the redis container is ready.
  • Added a startupProbe (TCP check on port 6379, 5s initial delay, 10s period, 3 failure threshold, 1s timeout) to the redis container in both YAMLs to confirm Redis readiness.

Copy link
Member

@ag-adampike ag-adampike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected!

A more robust "exec-style" health check for Redis (similar to our other deployment examples) would be preferred to enable Cloud Run to establish the dependency order, but sadly isn't available for Cloud Run. In the absence of that, the TCP readiness check parameters should be sufficient to ensure that Redis is actually healthy and appeared to consistently do the trick in our testing.

LGTM! 🎉

@ag-rdoucette ag-rdoucette merged commit bcda56d into main May 28, 2025
@ag-rdoucette ag-rdoucette deleted the ron/solutions/cloudrun-dependency-addition branch May 28, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants