item update behaviour to ignore manual changes #202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @odise 👋 I took a look at this PR and the issue. In regards to the null behaviour, making null ignore existing values would be a breaking change. Currently, null or omitting the attribute removes the field in 1Password. But as for the empty string behaviour a fix for this was implemented and released in v3.0.1. So you are now able to set the fields username and url to "" in order to clear them! I am going to close the PR and issue but please feel free to tag me if you have any other questions or want to discuss this further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #201 for
usernameandurlitem properties. Please let me know what you think.