Skip to content

Conversation

@harshils23
Copy link
Collaborator

@harshils23 harshils23 commented Mar 21, 2025

made 2 = to 3 = for correct equality check

Resolves #240

@harshils23 harshils23 changed the title changed equality and updated for tests; formatting Fix Equality Check Bug in typescript generator file Mar 21, 2025
Copy link
Contributor

@MOmarMiraj MOmarMiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, Please ensure your commits are verified as your unable to merge unless its verified.

@harshils23 harshils23 force-pushed the harshil/fix-equality branch 2 times, most recently from 31e7ea9 to 88a9090 Compare March 25, 2025 19:49
@harshils23 harshils23 force-pushed the harshil/fix-equality branch from 88a9090 to 96d56a0 Compare March 25, 2025 19:55
@harshils23 harshils23 merged commit 8c8041c into 1Password:main Mar 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change == to === for JS Reviver Functions

2 participants