fix(context): контракт addWorkspace(URI) — нормализованный через Absolute.uri

[nixel2007]

Summary

• AbstractServerContextAwareTest.initServerContext(Path, boolean) — оборачивает configurationRoot.toUri() в Absolute.uri(...) перед addWorkspace. Это центральный путь инициализации тестового workspace'а; callsite-ы передают сюда в том числе не-канонизованные Path (@TempDir от JUnit, относительные Path.of("./...")).
• AnalyzeProjectOnStartTest.TEST_WORKSPACE_URI инициализируется через Absolute.uri("file:///test-analyze-workspace") — фикспойнт нормализации на JVM-инициализации.
• ServerContextProvider.addWorkspace(URI, ?) — короткая Javadoc-нота: URI должен быть нормализован через Absolute.uri, иначе clear() / removeWorkspace не найдут запись по ключу.
• TestUtils.getServerContextForFile — старый throw on >1 contexts восстановлен (отменяет test-only смягчение из 2e19715c93).

Why

Симптом на macOS: Multiple ServerContexts registered. Use getDocumentContextFromFile(path, serverContext) ... валит 7 тест-классов через FAKE_DOCUMENT_URI.

Корневая утечка — на macOS JUnit @TempDir создаёт путь под /var/folders/..., а это симлинк на /private/var/folders/.... Цепочка:

@TempDir Path tempDir            # = /var/folders/.../junit-NNN/  (через симлинк)
initServerContext(tempDir, ...)  # configurationRoot.toUri() = file:///var/folders/.../
addWorkspace(uri)                # contexts.put(non-canonical-uri)
...
provider.clear()                 # removeWorkspace(WF(uri.toString()))
  → Absolute.uri(uri.toString()) # внутри File.getCanonicalFile() резолвит симлинк
                                 # → file:///private/var/folders/.../
  → contexts.remove(canonical)   # промах: stored key != canonical
                                 # workspace переживает cleanup

Дальше leak копится в contexts, и в следующем тест-классе initServerContext(PATH_TO_METADATA) делает contexts.size() ≥ 2. TestUtils.getServerContextForFile ловит это throw'ом.

На Linux то же @TempDir лежит под /tmp/junit-NNN/, /tmp — обычная директория, не симлинк, Absolute.uri round-trip identity, утечки нет.

Фикс — нормализовать URI в одной точке (initServerContext), через которую идут все callsite-ы с произвольным Path. Тогда ключ в contexts всегда фикспойнт Absolute.uri, и clear() стабильно находит и удаляет.

Test plan

• ./gradlew test -PmaxParallelForks=2 локально (Linux) — все 1664 теста зелёные.
• Java CI matrix (Ubuntu/macOS/Windows × JDK 21/25) — проверить, что 7 ранее упавших Mac/Win-тестов (ExpressionTreeComparersTest, ExpressionTreeBuildingVisitorTest, ExpressionParseTreeRewriterTest, ModuleReferenceTest, UseDirectiveScannerTest, BlockKeywordMatcherTest, ConfigurationModuleMembersProviderTest) теперь зелёные.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf0e4c79-2b7c-4a59-9e38-0fb44eb2be4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/server-context-provider-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR tightens and documents the ServerContextProvider.addWorkspace(URI, …) contract by requiring a URI normalized via Absolute.uri(...), adding a runtime check to fail fast when callers violate it. This prevents workspace cleanup/key mismatches across OSes (notably macOS/Windows canonicalization differences) and restores a stricter guard in test utilities to surface leaked workspaces instead of masking them.

Changes:

• Enforced addWorkspace(URI, …) to only accept Absolute.uri(...)-normalized URIs via a runtime assertion.
• Updated CLI and test call sites to pass normalized workspace URIs and to use the same normalized URI when setting WorkspaceContextHolder.
• Restored TestUtils behavior to throw when multiple ServerContext instances are registered (forcing tests to be explicit and helping detect cleanup leaks).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContextProvider.java	Documents and enforces the normalized-URI contract for workspace registration to prevent cleanup/remove mismatches.
src/main/java/com/github/_1c_syntax/bsl/languageserver/cli/AnalyzeCommand.java	Normalizes workspace URI before registering workspace and before entering WorkspaceContextHolder.
src/main/java/com/github/_1c_syntax/bsl/languageserver/cli/FormatCommand.java	Normalizes workspace URI before registering workspace and before entering WorkspaceContextHolder.
src/test/java/com/github/_1c_syntax/bsl/languageserver/util/TestUtils.java	Restores strict exception on multiple contexts to catch leaked workspaces; keeps deterministic context selection rules.
src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/SemanticTokensProviderTest.java	Updates test workspace registration to use normalized workspace URI.
src/test/java/com/github/_1c_syntax/bsl/languageserver/context/computer/MethodSymbolComputerTest.java	Updates test workspace registration to use normalized workspace URI.
src/test/java/com/github/_1c_syntax/bsl/languageserver/context/AbstractServerContextAwareTest.java	Normalizes workspace URIs used to create contexts to satisfy the new addWorkspace contract across OSes.
src/test/java/com/github/_1c_syntax/bsl/languageserver/AnalyzeProjectOnStartTest.java	Normalizes the synthetic test workspace URI to satisfy the new addWorkspace contract.

[github-actions]

Test Results

2 328 files  ±0  2 328 suites  ±0   1h 20m 10s ⏱️ +18s
1 664 tests ±0  1 664 ✅ ±0  0 💤 ±0  0 ❌ ±0 
9 984 runs  ±0  9 984 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a8522d9. ± Comparison against base commit 2e19715.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud