Регрессионный тест: QueryParseError больше не даёт FP на запросе с функцией СТРОКА#3979
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix query parse error with temporary tables
Регрессионный тест: QueryParseError больше не даёт FP на запросе с функцией СТРОКА
May 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test ensuring QueryParseError does not report a false positive for a valid query using СТРОКА() in a join condition with parameterized fields, matching issue #3169.
Changes:
- Added the issue query as a valid fixture case.
- Added a test comment documenting the regression scenario and issue reference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/test/resources/diagnostics/QueryParseErrorDiagnostic.bsl |
Adds the valid query sample from issue #3169 to the diagnostic fixture. |
src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/QueryParseErrorDiagnosticTest.java |
Documents that the expected diagnostic count must remain unchanged for this regression case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3169 сообщал о ложном срабатывании
QueryParseErrorна запросе с функциейСТРОКА()в условии соединения и полями, передаваемыми через параметры (&ар_Валюта,&Период).Воспроизведение на текущем develop (bsl-parser
0.34.1) показало, что FP больше не воспроизводится — точный запрос из issue корректно парсится и не подсвечивается. Проблема устранена на стороне bsl-parser. Изменения фиксируют это регрессионным тестом.Изменения
QueryParseErrorDiagnostic.bsl— добавлен полный запрос из issue как валидный кейс; число ожидаемых диагностик не меняется (3), что подтверждает отсутствие срабатывания.QueryParseErrorDiagnosticTest— пояснительный комментарий со ссылкой на issue.Производственный код не затронут.