Fixes Upper/Lower Casing for include paths#487
Merged
majcosta merged 5 commits into1dot13:masterfrom Aug 17, 2025
Merged
Conversation
types.h, zconf.h and zlib.h were renamed so that global includes like Types.h are not used.
majcosta
requested changes
Aug 16, 2025
Contributor
majcosta
left a comment
majcosta
left a comment
There was a problem hiding this comment.
just three lines of noops left on the patch, otherwise it's great
BeatAroundTheBuscher
force-pushed
the
linux_setup2
branch
2 times, most recently
from
80a6527 to
59fe6e6
Compare
BeatAroundTheBuscher
force-pushed
the
linux_setup2
branch
from
59fe6e6 to
d6462a8
Compare
BeatAroundTheBuscher
force-pushed
the
linux_setup2
branch
from
d6462a8 to
e66e6ec
Compare
majcosta
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a cleaner version of #469 and makes it obsolete
This will help Operation Systems/File Systems which are pedantic about
upper/lower casing to remember already compiled obj/lib files. This means
following messages will not show up anymore
File '/home/xyz/git/source/Lua/luaconf.h' does not exist.
Must remake target '/home/xyz/git/source/Lua/luaconf.h'.
Due to that some files existed in different casing (f. ex. ZLIB.H and zlib.h)
the filenames have been changed to lower casing.
"types.h" was also changed to lower case to avoid system libraries to be used.