Skip to content

Fix discrepant TOPTION values in GameSettings.cpp#536

Merged
majcosta merged 1 commit into
1dot13:masterfrom
majcosta:pr_fix_default_settings
Oct 10, 2025
Merged

Fix discrepant TOPTION values in GameSettings.cpp#536
majcosta merged 1 commit into
1dot13:masterfrom
majcosta:pr_fix_default_settings

Conversation

@majcosta
Copy link
Copy Markdown
Contributor

Ja2_Settings was supposed to be automatically generated but over time we started to edit defaults either there or in GameSettings.cpp inconsistently

Ja2_Settings was supposed to be automatically generated but over time we
started to edit defaults either there or in GameSettings.cpp inconsistently
@majcosta majcosta requested a review from kitty624 October 10, 2025 00:17
Copy link
Copy Markdown
Contributor

@kitty624 kitty624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@majcosta majcosta merged commit c6fd81d into 1dot13:master Oct 10, 2025
@majcosta majcosta deleted the pr_fix_default_settings branch October 10, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants